Skip to content

Add unifi-network extension#16323

Closed
lewjuh wants to merge 3 commits intoraycast:mainfrom
lewjuh:ext/unifi-network
Closed

Add unifi-network extension#16323
lewjuh wants to merge 3 commits intoraycast:mainfrom
lewjuh:ext/unifi-network

Conversation

@lewjuh
Copy link
Contributor

@lewjuh lewjuh commented Jan 12, 2025

Description

Screencast

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jan 12, 2025
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Did you see the UniFi extension before creating this?

@pernielsentikaer pernielsentikaer self-assigned this Jan 21, 2025
@lewjuh
Copy link
Contributor Author

lewjuh commented Jan 22, 2025

Hi 👋

Did you see the UniFi extension before creating this?

Hey! Ah, sadly I did not. This does differ in that it uses the official UniFi API recently released, but understand if dups aren't wanted in the store.

@pernielsentikaer
Copy link
Collaborator

Hi @lewjuh 👋

I spoke with the author of the other extension, he is willing to let you take over the ownership of current and update it with your code - could you do that instead of opening a new? Feel free to change author too when you do

Do you have any questions?

@lewjuh
Copy link
Contributor Author

lewjuh commented Jan 27, 2025

Hi @lewjuh 👋

I spoke with the author of the other extension, he is willing to let you take over the ownership of current and update it with your code - could you do that instead of opening a new? Feel free to change author too when you do

Do you have any questions?

@pernielsentikaer Hey, thanks for sorting that, I appreciate it!

Happy to do that, is there any concern about people who have the old version installed? How does the updating work on raycast extensions for a user?

@pernielsentikaer
Copy link
Collaborator

Let's see if we can come up with a way. We should follow the best approach by using an API key, as you're doing, instead of relying on a username/password. We could make the new preference required and remove the two other preferences; that will force the user to add the key.

Another option is to set the new preference as optional and show a special view to let the user know about the change and guide them a bit better on how to do that.

The second approach could be a cool thing, but it might be overkill.

- linting fixes
- Enhance Unifi integration with new device stats and preferences, update hooks and components for improved data handling
@lewjuh
Copy link
Contributor Author

lewjuh commented Jan 31, 2025

@pernielsentikaer Will look at doing the latter, to try make it as easy as possible!

Have updated and refactored this for now as needed some extra function.

@pernielsentikaer
Copy link
Collaborator

So is this already ready for review?

@lewjuh
Copy link
Contributor Author

lewjuh commented Feb 3, 2025

So is this already ready for review?

Sorry nope, just refactored and added to my code, i need to look at the other extension to see how best to integrate it.

@pernielsentikaer
Copy link
Collaborator

Awesome, thanks for checking. Since we're taking it over, it's nice if we can do it as softly as possible 😊

@lewjuh
Copy link
Contributor Author

lewjuh commented Feb 16, 2025

@pernielsentikaer Hey mate, wasnt sure how exactly to go about updating the other one but just went and directly updated it. #17101

Let me know if thats okay, i went for the option of prompting to update the user but still having the legacy stuff work. Can probably close this now and move over to their to review.

@lewjuh lewjuh mentioned this pull request Feb 17, 2025
5 tasks
@pernielsentikaer
Copy link
Collaborator

Closing this in favor of #17101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dont close Won't be closed by stalebot new extension Label for PRs with new extensions status: awaiting response from dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants