Conversation
|
Congratulations on your new Raycast extension! 🚀 You can expect an initial review within five business days. Once the PR is approved and merged, the extension will be available on our Store. |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Did you see the UniFi extension before creating this?
Hey! Ah, sadly I did not. This does differ in that it uses the official UniFi API recently released, but understand if dups aren't wanted in the store. |
|
Hi @lewjuh 👋 I spoke with the author of the other extension, he is willing to let you take over the ownership of current and update it with your code - could you do that instead of opening a new? Feel free to change author too when you do Do you have any questions? |
@pernielsentikaer Hey, thanks for sorting that, I appreciate it! Happy to do that, is there any concern about people who have the old version installed? How does the updating work on raycast extensions for a user? |
|
Let's see if we can come up with a way. We should follow the best approach by using an API key, as you're doing, instead of relying on a username/password. We could make the new preference required and remove the two other preferences; that will force the user to add the key. Another option is to set the new preference as optional and show a special view to let the user know about the change and guide them a bit better on how to do that. The second approach could be a cool thing, but it might be overkill. |
- linting fixes - Enhance Unifi integration with new device stats and preferences, update hooks and components for improved data handling
|
@pernielsentikaer Will look at doing the latter, to try make it as easy as possible! Have updated and refactored this for now as needed some extra function. |
|
So is this already ready for review? |
Sorry nope, just refactored and added to my code, i need to look at the other extension to see how best to integrate it. |
|
Awesome, thanks for checking. Since we're taking it over, it's nice if we can do it as softly as possible 😊 |
|
@pernielsentikaer Hey mate, wasnt sure how exactly to go about updating the other one but just went and directly updated it. #17101 Let me know if thats okay, i went for the option of prompting to update the user but still having the legacy stuff work. Can probably close this now and move over to their to review. |
|
Closing this in favor of #17101 |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder