Skip to content

Add gopass extension#1609

Merged
pernielsentikaer merged 6 commits intoraycast:mainfrom
bake:gopass
Jun 14, 2022
Merged

Add gopass extension#1609
pernielsentikaer merged 6 commits intoraycast:mainfrom
bake:gopass

Conversation

@bake
Copy link
Contributor

@bake bake commented May 6, 2022

Description

Add an extension for the gopass password manager. It currently only supports copying and pasting passwords.

For pasting I use Clipboard.paste which for some reason doesn't seem to be working. Could you please have a look at it? I might be missing something. Copying is done by gopass itself.

I don't have a screen to create a 2000x1250 screenshot and Slack prints an error to its console when I try to login to your community, this will have to be added before merging.

Screencast

screenshot

Checklist

@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

@raycastbot raycastbot added the new extension Label for PRs with new extensions label May 6, 2022
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bake 👋

Thanks for your contribution! 🔥

I have some feedback ready for you:

  • There is no validation If you don't have gopass, the loader keeps spinning forever, and no way for the user to understand what's going on:

CleanShot 2022-05-10 at 14 05 19@2x

  • After installing it (without setup - which fails for me(?)) it still just loads.

I think we need to address this and update the README so it's able to read a bit more about it 😄

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this May 10, 2022
@bake
Copy link
Contributor Author

bake commented May 20, 2022

Hi @pernielsentikaer, thank you for the feedback.

The user should have been notified when gopass isn't installed, but I missed that I can't use multiple catch on a promise. In case Raycast can not find gopass, a toast is shown.

I also added a minimal readme file.

Is the paste option working for you?

@bake bake requested a review from pernielsentikaer May 20, 2022 12:50
@bake
Copy link
Contributor Author

bake commented Jun 14, 2022

Hi @pernielsentikaer, I hope I don't bother you and the review request worked. Did you have the time to check the updated version? :)

@pernielsentikaer
Copy link
Collaborator

I'm not sure why I missed this, sorry about that! I think that we should merge it and see how it goes 🔥

@pernielsentikaer
Copy link
Collaborator

I don't have gopass working but I tried to add this action <Action title="Copy Password to Clipboard" onAction={() => Clipboard.paste("test")} /> and it works as expected, let's try to merge it and see how it goes 😄

If you await works as it should, then it should be working fine 😄

@pernielsentikaer
Copy link
Collaborator

Let's get it merged, added metadata image and icons

@pernielsentikaer pernielsentikaer merged commit bed5623 into raycast:main Jun 14, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/bake/gopass

@bake
Copy link
Contributor Author

bake commented Jun 14, 2022

@pernielsentikaer Thank you so much for the support, icons and the screenshot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new extension Label for PRs with new extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants