Skip to content

Update calist extension#14039

Closed
ridemountainpig wants to merge 1 commit intoraycast:mainfrom
ridemountainpig:calist
Closed

Update calist extension#14039
ridemountainpig wants to merge 1 commit intoraycast:mainfrom
ridemountainpig:calist

Conversation

@ridemountainpig
Copy link
Contributor

Description

Fix the day of the week is displayed incorrectly for issue #13968.

Screencast

CleanShot 2024-08-16 at 10 11 19
CleanShot 2024-08-16 at 10 21 04

Checklist

@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @astrit you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: calist Issues related to the calist extension labels Aug 16, 2024
@pernielsentikaer
Copy link
Collaborator

Thanks for the fix, @astrit can you check this?

@pernielsentikaer pernielsentikaer self-assigned this Aug 16, 2024
@astrit
Copy link
Contributor

astrit commented Aug 19, 2024

@ridemountainpig

Much appreciated for the fix!
Unfortunately there is conflict and the extension has been renamed.

I ditched entirely the title method since spacing is not even and many factors in play so added new row with custom SVG to show the day names.

If is fine I have accredited you in the package json for this change and did them manually
Reach me out on Slack if you want to talk about these changes ✌️

CleanShot 2024-08-19 at 17 29 50@2x

I have done the fixes locally
CleanShot 2024-08-19 at 17 28 49@2x

@ridemountainpig
Copy link
Contributor Author

@astrit Thanks for your reply, and the changes look good to me. I appreciate the accreditation in the package.json. 👍

@astrit astrit mentioned this pull request Aug 19, 2024
10 tasks
@astrit
Copy link
Contributor

astrit commented Aug 19, 2024

@astrit Thanks for your reply, and the changes look good to me. I appreciate the accreditation in the package.json. 👍
The PR is opened now and if you are OK we can close this one!
#14086

@ridemountainpig
Copy link
Contributor Author

@astrit Thanks for your reply, and the changes look good to me. I appreciate the accreditation in the package.json. 👍
The PR is opened now and if you are OK we can close this one!
#14086

LGTM 👍

@ridemountainpig ridemountainpig deleted the calist branch November 1, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: calist Issues related to the calist extension extension fix / improvement Label for PRs with extension's fix improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants