[Sonos] handle a stale group choice better#11969
Merged
pernielsentikaer merged 4 commits intoraycast:mainfrom Apr 24, 2024
Merged
[Sonos] handle a stale group choice better#11969pernielsentikaer merged 4 commits intoraycast:mainfrom
pernielsentikaer merged 4 commits intoraycast:mainfrom
Conversation
11d6aaf to
de3d597
Compare
de3d597 to
45d9cff
Compare
pernielsentikaer
approved these changes
Apr 24, 2024
Collaborator
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
Contributor
|
Published to the Raycast Store: |
Collaborator
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes adresses a problem that appears when the group configuration changes in the network. If the user has previously explicitly picked a group to control, but the group no longer is available, the command would fail.
This is pretty likely to happen where merging and unmerging groups and devices is common. I do that a lot myself, that's how I realised this was an issue.
The new logic is able to detect that the stored group choice is stale, and falls back to the "fallback group choice" that was in place already.