Skip to content

Update power-management extension#11917

Merged
pernielsentikaer merged 3 commits intoraycast:mainfrom
bbatsche:ext/power-management
Apr 30, 2024
Merged

Update power-management extension#11917
pernielsentikaer merged 3 commits intoraycast:mainfrom
bbatsche:ext/power-management

Conversation

@bbatsche
Copy link
Contributor

@bbatsche bbatsche commented Apr 21, 2024

Description

I added three new commands to the Power Management extension:

  • Enable low power mode
  • Disable low power mode
  • Low power mode details

The first two simply try to set low power mode on or off (so the user doesn’t have to know what the current state is, unlike “toggle”). The third allows a user to see the current low power settings for both AC charger and battery power and then toggle them individually.

There was also some refactoring in the menubar command. In my testing I had noticed some delays in the menubar UI changing in response to low power mode being toggled from elsewhere within Raycast. This should address those.

Screencast

Checklist

- New low power commands
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: power-management Issues related to the power-management extension OP is contributor The OP of the PR is a contributor of the extension labels Apr 21, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Apr 21, 2024

Thank you for your contribution! 🎉

🔔 @sasivarnan @erics118 @iamyeizi you might want to have a look.

@erics118
Copy link
Contributor

The refactor looks good pretty nice!

Perhaps just name the settings command as Low Power Mode Settings, as that's what the list nav title says, and makes sense.

It also looks like there's a bug with toggling the enabled/disabled in the settings command. After toggling it once, it seems that you need to re-open the extension before you can toggle it again:

CleanShot.2024-04-20.at.20.42.38.mp4

@bbatsche
Copy link
Contributor Author

@erics118 Good catch on the bug! Looks like it’s related to not having the menu bar command active which I’d neglected to test. I’ll get it fixed up!

@pernielsentikaer
Copy link
Collaborator

Thanks for the contribution @bbatsche 🔥 Is this ready for another review?

@pernielsentikaer pernielsentikaer self-assigned this Apr 22, 2024
@bbatsche
Copy link
Contributor Author

@pernielsentikaer yes! Thank you, it should be ready for another check.

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Apr 23, 2024

I gave it a spin and it works for me 🔥

@sasivarnan do you want to check it?

@sasivarnan
Copy link
Contributor

Apologies for the delay. I have tested the modifications, and everything functions as anticipated.

@pernielsentikaer pernielsentikaer merged commit 341c660 into raycast:main Apr 30, 2024
@github-actions
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/sasivarnan/power-management

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: power-management Issues related to the power-management extension OP is contributor The OP of the PR is a contributor of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants