Skip to content

Add mac-app-store-search extension#11903

Merged
raycastbot merged 12 commits intoraycast:mainfrom
say4n:ext/mac-app-store-search
Apr 29, 2024
Merged

Add mac-app-store-search extension#11903
raycastbot merged 12 commits intoraycast:mainfrom
say4n:ext/mac-app-store-search

Conversation

@say4n
Copy link
Contributor

@say4n say4n commented Apr 19, 2024

Description

Adds an extension to search for apps on the Mac App Store.

Screencast

Checklist

- update assets
- search works
- adds skeleton
- Initial commit
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

We will aim to make the initial review within five working days. Once the PR is approved and merged, the extension will be available on our Store.

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Apr 19, 2024
@xilopaint
Copy link
Contributor

Hey, you need to add metadata images for the Store.

@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

Sure, let me go ahead and add some. 🚀

- adds screenshots for store listing.
- update node versions
- Create node.js.yml
@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

Done!

@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

(fixed the linter nag on screenshot dimensions, should have probably run npm run lint before I pushed)

@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

do you think it is worth updating the npm build script to also run the linter perhaps? something like:

-    "build": "ray build -e dist",
+    "build": "lint && ray build -e dist",

@xilopaint
Copy link
Contributor

  1. I recommend you use the Window Capture feature to take pretty screenshots in the appropriate size. You can set a hotkey in the Advanced tab of Raycast Settings. With the Window Capture feature, the screenshots will not show the icon for the develop mode.

  2. The search bar placeholder is not properly capitalized ("mac app store" instead of "Mac App Store").

@xilopaint
Copy link
Contributor

do you think it is worth updating the npm build script to also run the linter perhaps? something like:

-    "build": "ray build -e dist",
+    "build": "lint && ray build -e dist",

By Raycast standards, lint, fix-lint, and build are separate scripts. I wouldn't change that because other developers who may contribute to your extension in the future may be used to that standard.

@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

I recommend you use the Window Capture feature to take pretty screenshots in the appropriate size. You can set a hotkey in the Advanced tab of Raycast Settings. With the Window Capture feature, the screenshots will not show the icon for the develop mode.

ah neat, I totally didn't know that was a thing -- instead I was doing it all by hand

The search bar placeholder is not properly capitalized ("mac app store" instead of "Mac App Store").

sure, let me fix that as well!

@xilopaint
Copy link
Contributor

Delete the copy of metadata images in the assets folder. There is no need to include them in README. When people open README from the Store, they will see the metadata images on top.

Also, your first two metadata images add no relevant information. I would delete them.

@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

done, thanks Arthur!

@xilopaint
Copy link
Contributor

Honestly, I'd suggest using the original App Store icon in the extension. If you prefer using your own icon, consider giving it rounded corners. You can use the Raycast Icon Maker for this: https://icon.ray.so/

@say4n
Copy link
Contributor Author

say4n commented Apr 20, 2024

cool, updated it -- didn't want to use one of those icons but whatever (the icon maker seems to break when i try to import in a custom svg icon), are we gtm here?

@xilopaint
Copy link
Contributor

xilopaint commented Apr 20, 2024

didn't want to use one of those icons

Actually, you don't need to. I suggested you use the Icon Maker to change your icon to use rounded corners. Here's a version of your own icon with rounded corners if you prefer to use:

icon

As I mentioned, in your place, I would rather use the App Store original icon, but it's also okay to use your own icon. I just find this icon a bit strange because of these nonsense black circles.

@say4n
Copy link
Contributor Author

say4n commented Apr 21, 2024

i've updated the icon, let's move with the one that i have at present :)

@say4n
Copy link
Contributor Author

say4n commented Apr 22, 2024

just following up: are we gtm, or are is there an ask here?

@xilopaint
Copy link
Contributor

In a couple of days @pernielsentikaer will review the PR.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • There is no loading indicator when searching
Raycast23042024-6gKAS43K.png.mp4
  • Most of the things I search for are not for macOS; is that intended? Try searching for GSE and check the first hit in the App Store; I'm just finding that it's not compatible with the MacBook.

  • Could you run Check for Updates in your Raycast, it looks like you're on an old version

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Apr 23, 2024
@say4n
Copy link
Contributor Author

say4n commented Apr 26, 2024

Good catch @pernielsentikaer, thanks! I have fixed the API search params and addressed the other comments!

@xilopaint
Copy link
Contributor

@say4n your metadata images show the previous icon version:

mac-app-store-search-0

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 0fecdf9 into raycast:main Apr 29, 2024
@github-actions
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/say4n/mac-app-store-search

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@say4n say4n deleted the ext/mac-app-store-search branch April 29, 2024 23:43
@say4n
Copy link
Contributor Author

say4n commented Apr 29, 2024

Thanks @pernielsentikaer, apologies for the tardiness!

@pernielsentikaer
Copy link
Collaborator

All good 🎉

Awesome to see it in the store 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new extension Label for PRs with new extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants