Add yafw extension by pablopunk · Pull Request #11894 · raycast/extensions

pablopunk · 2024-04-19T16:40:02Z

Description

Are you tired of apps that claim to compress videos but they're just ffmpeg wrappers? Me neither, so I decided to create a Raycast extension that does exactly that

Screencast

(no need to say I compressed this screencast with YAFW)

CleanShot.2024-04-19.at.18.45.26.yafw.balanced.mp4

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- welcome - screenshots - Finder - link - quote - ▶︎ - typo - again, better compression settings - better compression values and text, fix removed files when adding them back manually, better output name - readme - unused fn - better compression settings and storage history management - fix history, new command, automatic stuff, unique arrays - it works - first commit

raycastbot · 2024-04-19T16:40:20Z

Congratulations on your new Raycast extension! 🚀

We will aim to make the initial review within five working days. Once the PR is approved and merged, the extension will be available on our Store.

pernielsentikaer

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

You could maybe check if ffmpeg is installed by checking the default paths instead (and keep the field optional if people installed it elsewhere)
You can maybe do something like how Brew or Display Placer installs packages.

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

extensions/yafw/src/videos.tsx

pernielsentikaer · 2024-04-23T10:51:03Z

extensions/yafw/src/videos.tsx

+                onAction={() => removeFromHistory(file)}
+                icon={{ source: Icon.Trash }}
+              />
+              <Action title="Clear All History" onAction={clearAllHistory} icon={{ source: Icon.Trash }} />


Suggested change

<Action title="Clear All History" onAction={clearAllHistory} icon={{ source: Icon.Trash }} />

<Action

title="Clear All History"

style={Action.Style.Destructive}

onAction={clearAllHistory}

icon={{ source: Icon.Trash }}

/>

pernielsentikaer · 2024-04-23T10:58:01Z

extensions/yafw/src/videos.tsx

+          }
+        />
+      ))}
+      {history == null && <Grid.Item key="loading" title="Loading history..." content="" />}


Suggested change

{history == null && <Grid.Item key="loading" title="Loading history..." content="" />}

pernielsentikaer · 2024-04-23T10:59:42Z

extensions/yafw/src/videos.tsx

+  };
+
+  return (
+    <Grid selectedItemId={"0"}>


Suggested change

<Grid selectedItemId={"0"}>

<Grid>

Add isLoading={} instead, set it with useState

- check for ffmpeg in the path - address pr comments

pablopunk · 2024-04-23T17:22:54Z

Thanks for the review @pernielsentikaer! I addressed all the comments 👌🏻

pernielsentikaer

Thanks for the corrections 🔥

Do you have a clue why the video I have selected seems to come back on every load (and on compleation)

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

pernielsentikaer · 2024-04-24T10:44:45Z

extensions/yafw/src/index.tsx

+    compressVideoFiles(files, compression).then((successfulFiles) => {
+      if (successfulFiles.length === 0) return;
+      successfulFiles.forEach((file) => Clipboard.copy({ file }));
+      navigation.push(<Videos files={successfulFiles} />);


Suggested change

navigation.push(<Videos files={successfulFiles} />);

try {

popToRoot();

launchCommand({ name: "history", type: LaunchType.UserInitiated });

} catch {

/* */

}

Maybe something like this instead

what's the advantage here? I'd rather keep the current behavior because of 2 reasons:

Passing the successfulFiles prop allows me to create a decorator for the new files (see screenshot below)

If you want to go back to compress more videos, you can just press Esc or the back arrow in the UI

WDYT?

That makes senes, you can maybe add a preference to let the user decide if it should popToRoot, Show compressed files(default) or just history upon completion

I'd prefer to keep it as it is for the first version, but I'll keep it in mind for the future 🙏🏻

pablopunk · 2024-04-24T12:16:59Z

extensions/yafw/src/index.tsx

+     * > Looks like the command is rendering a lot without any changes. This might indicate an rendering loop caused by a `setState` not being wrapped in a `useEffect`.
+     * > This will degrade the performances of Raycast and Raycast might arbitrarily decide to terminate the extension if it happens too many times.
+     */
+    setInterval(lookForVideoSources, 3000);


Do you have a clue why the video I have selected seems to come back on every load (and on compleation)

@pernielsentikaer this is probably caused by this interval, which I'm still not sure about. I made it so if you open the extension and only then you go to select/copy some videos, it regularly checks if there are more videos in the clipboard or the finder.

I could disable this behavior if you think is not a good idea

I think it's the tradeoff that you'll need to keep it open, much better than using a lot of renders to keep it, maybe we can do something like this "warning"

hmmm it's not really during compression, it's right on that selection screen

user opens command -> no videos selected -> user goes to Finder to select or copy some videos -> comes back to the command -> the command auto-refreshes the list with the new files

to be honest I think I'm overthinking a bit here, I think I'll remove the setInterval and add a warning saying

To add videos automatically, copy them or select them in the Finder and launch this command again

☝🏻 this should also solve going back from the history and seeing the compressed video auto-selected

pernielsentikaer

Thanks for the corrections, I gave it another spin:

Clear All History action does not work when you are in the compressed history view (and in the normal history view, you might want to add a confirmation alert with remember user choice).

Raycast25042024-KGtzXnU8.png.mp4

It seems it automatically copies the file to the clipboard even though there is an action to copy it; it is better to let the user choose

pablopunk · 2024-04-26T12:21:18Z

@pernielsentikaer there's an action to copy because you might convert more than one file at the same time, so I want to give the option to copy any of those single files afterwards.

IMO the usual flow will be compressing just one file, and I'd like to keep the automatic copy-to-clipboard behavior in this case, I find it handy (they'll have clipboard history in raycast anyway).

Regarding the Clear All History, yeah I'm only removing the "old" files (i.e. the ones you are not converting right now). I'll change it to remove all 👍🏻

The only problem now is that the CLI is not letting me update the PR for some reason 🤔

pernielsentikaer · 2024-04-26T12:41:38Z

Just do as it says, go to your fork (the link) and sync it 🙂

pernielsentikaer

Hi 👋

Looks good to me, approved 🔥

j3lte · 2024-04-30T09:18:58Z

@pernielsentikaer is it me or is it not published in the Store? Can't seem to find it...

pablopunk · 2024-04-30T10:08:16Z

@j3lte looks like the job failed https://github.com/raycast/extensions/actions/runs/8884540958/job/24393845273

not sure if i can help with that

pernielsentikaer · 2024-04-30T10:42:25Z

Let me have a look, thanks for flagging @j3lte

pernielsentikaer · 2024-04-30T10:57:06Z

I should be there in two minutes. I accidentally added a style property twice 🙂

raycastbot added the new extension Label for PRs with new extensions label Apr 19, 2024

pernielsentikaer requested changes Apr 23, 2024

View reviewed changes

pernielsentikaer self-assigned this Apr 23, 2024

Update yafw extension

a021b46

- check for ffmpeg in the path - address pr comments

pablopunk requested a review from pernielsentikaer April 23, 2024 17:22

check custom path and regular PATH

6d86b1c

pernielsentikaer requested changes Apr 24, 2024

View reviewed changes

pablopunk commented Apr 24, 2024

View reviewed changes

pablopunk requested a review from pernielsentikaer April 24, 2024 18:47

remove setInterval and add info text

9510cee

pernielsentikaer requested changes Apr 25, 2024

View reviewed changes

clear current files too

46ee963

pablopunk requested a review from pernielsentikaer April 26, 2024 13:02

Update extensions/yafw/src/videos.tsx

66765ab

pernielsentikaer approved these changes Apr 29, 2024

View reviewed changes

Update CHANGELOG.md and optimise images

f4919db

raycastbot merged commit e53e194 into raycast:main Apr 29, 2024

pablopunk deleted the ext/yafw branch April 30, 2024 16:50

tonypinkevych mentioned this pull request May 1, 2024

Add Video/GIF Modification extension #12068

Closed

5 tasks

-      navigation.push(<Videos files={successfulFiles} />);
+try {
+        popToRoot();
+        launchCommand({ name: "history", type: LaunchType.UserInitiated });
+      } catch {
+        /* */
+      }

Conversation

pablopunk commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screencast

Checklist

Uh oh!

raycastbot commented Apr 19, 2024

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pablopunk commented Apr 23, 2024

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pablopunk Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

pablopunk commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pernielsentikaer commented Apr 26, 2024

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

j3lte commented Apr 30, 2024

Uh oh!

pablopunk commented Apr 30, 2024

Uh oh!

pernielsentikaer commented Apr 30, 2024

Uh oh!

pernielsentikaer commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pablopunk commented Apr 19, 2024 •

edited

Loading

pablopunk Apr 24, 2024 •

edited

Loading

pablopunk commented Apr 26, 2024 •

edited

Loading