Skip to content

GitHub: Set Open in Browser as a primary action#11798

Merged
thomaslombart merged 13 commits intoraycast:mainfrom
d-mitrofanov-v:ext/github
Apr 22, 2024
Merged

GitHub: Set Open in Browser as a primary action#11798
thomaslombart merged 13 commits intoraycast:mainfrom
d-mitrofanov-v:ext/github

Conversation

@d-mitrofanov-v
Copy link
Contributor

@d-mitrofanov-v d-mitrofanov-v commented Apr 13, 2024 •
edited
Loading

Description

Screencast

Checklist

Update github extension
17a114d 
- add ability to open pull requests in browser as primary action
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: github Issues related to the github extension labels Apr 13, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Apr 13, 2024 •
edited
Loading

Thank you for your first contribution! 🎉

🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @peppy @aeither @marcotf @qeude @nesl247 @xilopaint @antonengelhardt @bangerang @wottpal you might want to have a look.

@thomaslombart thomaslombart self-assigned this Apr 15, 2024
thomaslombart
thomaslombart suggested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This removes the Open in Browser action in the details view. Could you add it back please?

Also the preference affects the other pull requests commands such as My Pull Request command, it'd be better to move it as a global preference.

@thomaslombart thomaslombart changed the title Update github extension GitHub: Set Open in Browser as a primary action Apr 18, 2024
@d-mitrofanov-v
Copy link
Contributor Author

d-mitrofanov-v commented Apr 19, 2024

Hi @thomaslombart. I've moved Open in Browser action back and made the preference global.

@raycastbot raycastbot added the OP is author The OP of the PR is the author of the extension label Apr 22, 2024
@thomaslombart thomaslombart merged commit 101fe2a into raycast:main Apr 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024

Published to the Raycast Store:
https://raycast.com/raycast/github

@raycastbot
Copy link
Collaborator

raycastbot commented Apr 22, 2024

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@d-mitrofanov-v).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pernielsentikaer pernielsentikaer Awaiting requested review from pernielsentikaer pernielsentikaer is a code owner

@bangerang bangerang Awaiting requested review from bangerang bangerang is a code owner

1 more reviewer

@thomaslombart thomaslombart thomaslombart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thomaslombart thomaslombart

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: github Issues related to the github extension OP is author The OP of the PR is the author of the extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-mitrofanov-v @raycastbot @thomaslombart