This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Supporting __partitioned__ interface#153
Merged
krfricke merged 5 commits intoray-project:masterfrom Oct 13, 2021
Merged
Conversation
Yard1
reviewed
Sep 14, 2021
krfricke
reviewed
Sep 14, 2021
Collaborator
krfricke
left a comment
There was a problem hiding this comment.
Thank you, this is a very thorough PR.
I just triggered CI so we can see if the tests pass. Can you also add the example to run_ci_examples.sh in the root directory?
Yard1
reviewed
Sep 14, 2021
Contributor
Author
CI doesn't seem start anymore. |
Collaborator
|
Ah sorry, it seems I have to manually trigger it every time. Just did! |
Contributor
Author
|
I have no idea how my changes could make any other test fail. |
Member
|
Looks like tests are being flaky on their own |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation for #152 .
Once MLDataSet and modin have support for partitioned in mainline their specialized implementation could be removed without limiting any functionality.