This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Merged
Conversation
Closed
matthewdeng
approved these changes
Feb 23, 2022
bveeramani
suggested changes
Feb 28, 2022
Member
bveeramani
left a comment
There was a problem hiding this comment.
Minor nitpick but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124.
Fixes device calculation to take into account fractional GPUs. But also raises a warning advising against this in the multi-worker case as sharing GPUs across workers will often lead to failures with NCCL training.
Test was run manually and passes.