Skip to content

[serve] Rename to Central Actor#9285

Closed
ijrsvt wants to merge 3 commits intoray-project:masterfrom
ijrsvt:rename
Closed

[serve] Rename to Central Actor#9285
ijrsvt wants to merge 3 commits intoray-project:masterfrom
ijrsvt:rename

Conversation

@ijrsvt
Copy link
Copy Markdown
Contributor

@ijrsvt ijrsvt commented Jul 3, 2020

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@rkooo567
Copy link
Copy Markdown
Contributor

rkooo567 commented Jul 3, 2020

Did we reach to the consensus for the name to central? I was thinking a head actor. (And in the same way, head dashboard). I think it'll be great to keep using the consistent terminology.

@ijrsvt
Copy link
Copy Markdown
Contributor Author

ijrsvt commented Jul 3, 2020

@rkooo567 Not necessarily. We can change it to "head" or "primary". I just wanted to open up this PR to make a) make sure I know what changes are required and b) to get this done before it slips my mind.

@AmplabJenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27867/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27922/
Test FAILed.

@ijrsvt
Copy link
Copy Markdown
Contributor Author

ijrsvt commented Jul 13, 2020

Closing to reopen with new name & no merge conflicts

@ijrsvt ijrsvt closed this Jul 13, 2020
@ijrsvt ijrsvt mentioned this pull request Jul 18, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants