Skip to content

Split hiredis from Redis and use it directly#9176

Merged
suquark merged 2 commits intoray-project:masterfrom
mehrdadn:hiredis-split
Jun 30, 2020
Merged

Split hiredis from Redis and use it directly#9176
suquark merged 2 commits intoray-project:masterfrom
mehrdadn:hiredis-split

Conversation

@mehrdadn
Copy link
Copy Markdown
Contributor

@mehrdadn mehrdadn commented Jun 28, 2020

Why are these changes needed?

The upstream hiredis repo is separate from that of Redis, and it has been updated with various Windows patches recently.

We can't pull in the Windows patches quite yet, but this PR switches to that repo to allow us to update them independently in the future.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jun 28, 2020

Can one of the admins verify this patch?

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jun 28, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27628/
Test PASSed.

@simon-mo
Copy link
Copy Markdown
Contributor

simon-mo commented Jun 29, 2020

We can't pull in the Windows patches quite yet

why?

simon-mo
simon-mo reviewed Jun 29, 2020
View reviewed changes
bazel/BUILD.hiredis
Comment on lines +30 to +31
"*.h",
"adapters/*.h",
Copy link
Copy Markdown
Contributor

@simon-mo simon-mo Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**/*.h wildcards?

Copy link
Copy Markdown
Contributor Author

@mehrdadn mehrdadn Jun 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would pull in the examples/ directory which we don't want. (Unless you mean I should use exclude?)

bazel/BUILD.hiredis
Comment on lines +8 to +9

cc_library(
Copy link
Copy Markdown
Contributor

@simon-mo simon-mo Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment why this is needed? (vs. directly merge it to cc_library(name = "hiredis"...

Copy link
Copy Markdown
Contributor Author

@mehrdadn mehrdadn Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I thought I kept the note for this, thanks for catching!

@mehrdadn
Copy link
Copy Markdown
Contributor Author

mehrdadn commented Jun 29, 2020 •
edited
Loading

@simon-mo We can't pull them because they're incompatible with some of the patches on our side and I haven't managed to find a way to get them working on Windows so far (whether with or without our patches).

@suquark suquark merged commit 79c4c67 into ray-project:master Jun 30, 2020
@mehrdadn mehrdadn deleted the hiredis-split branch June 30, 2020 01:16
@mehrdadn mehrdadn mentioned this pull request Jul 3, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suquark suquark suquark approved these changes

@simon-mo simon-mo simon-mo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mehrdadn @AmplabJenkins @simon-mo @suquark @web-flow