[Serve] Serve failure test hotfix.#8928
Closed
rkooo567 wants to merge 1 commit intoray-project:masterfrom
Closed
Conversation
|
Can one of the admins verify this patch? |
|
Test FAILed. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When
ray.get(master_actor.create_backend.remote(backend_tag, backend_config, replica_config))is called byserve.create_backend, this raises anRayActorErrorexception because master_actor just literally killed. At the release test, we don't catch this exception, so it crashes the driver (because there's uncaught exception). This kills Raylet & GCS server, which introduces a weird errors in there.I don't know what's the right behavior in this case, but it seems like wrapping
serve.create_backend,serve.create_endpoint,serve.delete_endpoint,serve.delete_endpointbyresolves the issue.
Conclusion: the problem is that we don't catch RayActorError anymore, and that crashes the driver. In the past, we manually caught RayActorError to retry actor task, but not anymore after we rely on Ray's actor retries mechanism. related PR: 4155d58)
##NOTE
This is a hotfix, and I am not sure if it is the right behavior you want. Feel free to reject the PR if we need other solutions.
Related issue number
Closes #8915
Checks
scripts/format.shto lint the changes in this PR.