[Core] Log output from different jobs to different drivers. #8885
[Core] Log output from different jobs to different drivers. #8885ericl merged 67 commits intoray-project:masterfrom
Conversation
…command-format
…and-runner-interactivity
…idriver-logging
| """ | ||
| redirect_output = self._ray_params.redirect_output | ||
|
|
||
| if redirect_output is None: |
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
|
test_tempfile still seems to be failing, does it pass locally? |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
Why are these changes needed?
This is a first step to handling ensuring that only output from the relevant job is sent to each driver. This PR will make each worker write its own output to a file titled
worker-{worker-id}.out(which it already does), but use produced output from jobs will now be written to a file titledworker-{worker-id}-{job-id}.out. stderr will also be redirected accordingly.Related issue number
First of 2 steps towards closing #4029.
Checks
scripts/format.shto lint the changes in this PR.No tests here. In some ways this is just a non-trivial refactoring in the sense that it shouldn't effect end behavior, thus it's sufficient to not break anything. When behavior changes (i.e. next PR where output is actually sent to specific drivers only), test cases will be included.