[autoscaler] Enable Rsync with Docker Containers #8527
Closed
ijrsvt wants to merge 4 commits intoray-project:masterfrom
Closed
[autoscaler] Enable Rsync with Docker Containers #8527ijrsvt wants to merge 4 commits intoray-project:masterfrom
ijrsvt wants to merge 4 commits intoray-project:masterfrom
Conversation
|
Can one of the admins verify this patch? |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
Contributor
|
Do you want to open a new PR to implement a CommandRunner and close this one? it's OK to re-use this one as well. |
Contributor
Author
|
I'll close this one
…On Mon, Jun 1, 2020 at 1:36 PM Simon Mo ***@***.***> wrote:
Do you want to open a new PR to implement a CommandRunner and close this
one? it's OK to re-use this one as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8527 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC5KQXAOBV2TB5NKPWSQRDRUQGOTANCNFSM4NGLZXEA>
.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray cannot currently rsync into or out of docker containers. This is a problem also for
ray submitwhich uses rsync;Related issue number
Closes #4183
Checks
scripts/format.shto lint the changes in this PR.