Skip to content

[serve] Push route table updates to HTTP proxy#7774

Merged
simon-mo merged 8 commits intoray-project:masterfrom
edoakes:push-route-table
Mar 30, 2020
Merged

[serve] Push route table updates to HTTP proxy#7774
simon-mo merged 8 commits intoray-project:masterfrom
edoakes:push-route-table

Conversation

@edoakes
Copy link
Copy Markdown
Collaborator

@edoakes edoakes commented Mar 27, 2020 •
edited
Loading

Why are these changes needed?

First step towards a "master actor" architecture. The HTTP proxy now has routing table updates pushed to it instead of periodically polling directly from the database.

Also pushes the router handle to the HTTP proxy instead of fetching it from GlobalState, removing the circular dependency on GlobalState entirely.

Checks

@edoakes edoakes requested a review from simon-mo March 27, 2020 17:00
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Can one of the admins verify this patch?

@simon-mo simon-mo self-assigned this Mar 27, 2020
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23800/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23805/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23806/
Test PASSed.

simon-mo
simon-mo approved these changes Mar 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoakes edoakes mentioned this pull request Mar 28, 2020
Merged
6 tasks
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 29, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23882/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 30, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23951/
Test FAILed.

@simon-mo simon-mo merged commit 3a53ea6 into ray-project:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@simon-mo simon-mo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edoakes @AmplabJenkins @simon-mo