Skip to content

[RLlib] Assert correct policy class being used in Worker.#7769

Merged
ericl merged 15 commits intoray-project:masterfrom
sven1977:assert_pytorch_policy_vs_tf_policy_in_workers
Mar 30, 2020
Merged

[RLlib] Assert correct policy class being used in Worker.#7769
ericl merged 15 commits intoray-project:masterfrom
sven1977:assert_pytorch_policy_vs_tf_policy_in_workers

Conversation

@sven1977
Copy link
Copy Markdown
Contributor

@sven1977 sven1977 commented Mar 27, 2020 •
edited
Loading

When creating a Worker, we now assert that it uses the TorchPolicy class iff use_pytorch is set in the config.

Related issue number

Checks

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Can one of the admins verify this patch?

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23783/
Test PASSed.

@ericl
Copy link
Copy Markdown
Contributor

ericl commented Mar 27, 2020

Lgtm

@ericl ericl self-assigned this Mar 27, 2020
@sven1977
Copy link
Copy Markdown
Contributor Author

sven1977 commented Mar 27, 2020

Waiting for re-testing after fixing remote Actor worker.get_policy() problem. Only checking on local Worker now (remote should be the same).

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23791/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23792/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23797/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23798/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23814/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 27, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23815/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 28, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23864/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 28, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23866/
Test PASSed.

sven1977 added 2 commits March 30, 2020 12:33
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into asse…
b8f1645 
…rt_pytorch_policy_vs_tf_policy_in_workers

� Conflicts:
�	rllib/utils/exploration/tests/test_explorations.py
@sven1977
Fix and LINT.
07acc97
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 30, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23936/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 30, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23942/
Test PASSed.

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 30, 2020
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 30, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23962/
Test FAILed.

@ericl ericl merged commit e356e97 into ray-project:master Mar 30, 2020
@sven1977 sven1977 deleted the assert_pytorch_policy_vs_tf_policy_in_workers branch March 31, 2020 16:24
@sven1977 sven1977 mentioned this pull request Apr 30, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sven1977 @AmplabJenkins @ericl