Fix TestTaskLeaseRenewal test failure#7765
Merged
raulchen merged 1 commit intoray-project:masterfrom Mar 29, 2020
Merged
Conversation
|
Can one of the admins verify this patch? |
|
Test FAILed. |
edoakes
approved these changes
Mar 27, 2020
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
We really should be using a mocked clock here instead of relying on timing, but this seems fine for now.
raulchen
approved these changes
Mar 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When sleep_time = 10 * initial_lease_period_ms_, test case fails, because the AsyncAddTaskLease function is expected to be called four times, but only three times. It's hard to determine the sleep_time value, so let's double it for now.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.