Skip to content

Windows process issues#7739

Merged
robertnishihara merged 9 commits intoray-project:masterfrom
mehrdadn:windows-processes
Mar 29, 2020
Merged

Windows process issues#7739
robertnishihara merged 9 commits intoray-project:masterfrom
mehrdadn:windows-processes

Conversation

@mehrdadn
Copy link
Copy Markdown
Contributor

@mehrdadn mehrdadn commented Mar 25, 2020

Why are these changes needed?

Addresses various issues related to processes on Windows.

Related issue number

#631

Checks

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 25, 2020

Can one of the admins verify this patch?

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 25, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23681/
Test FAILed.

robertnishihara
robertnishihara approved these changes Mar 29, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please fix linting.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 29, 2020

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23893/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 29, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23894/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 29, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23898/
Test PASSed.

@robertnishihara robertnishihara merged commit fc23f79 into ray-project:master Mar 29, 2020
@mehrdadn mehrdadn deleted the windows-processes branch March 29, 2020 21:29
@mehrdadn mehrdadn mentioned this pull request May 28, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdadn @AmplabJenkins @robertnishihara @web-flow