[Serve] Improve Serialization#7688
Merged
simon-mo merged 2 commits intoray-project:masterfrom Mar 29, 2020
Merged
Conversation
|
Can one of the admins verify this patch? |
|
Test PASSed. |
rkooo567
approved these changes
Mar 23, 2020
Using `__dict__` to serialize objects improve the overall noop query latency Rough benchmark before 25% in 0.0054 secs 50% in 0.0060 secs 75% in 0.0066 secs 90% in 0.0068 secs after 25% in 0.0044 secs 50% in 0.0046 secs 75% in 0.0048 secs 90% in 0.0059 secs
b2d0f7c to
bda4076
Compare
|
Test PASSed. |
alindkhare
reviewed
Mar 27, 2020
| clone.async_future = None | ||
| # We can't use cloudpickle due to a recursion issue | ||
| return pickle.dumps(clone) | ||
| clone = copy.copy(self).__dict__ |
Member
There was a problem hiding this comment.
Can you add comment for using cloudpickle and __dict__ ? Because looking at the previous comments
We can't use cloudpickle due to a recursion issue
Is this fixed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
__dict__to serialize objects improve the overall noop query latencyRough benchmark
before
25% in 0.0054 secs
50% in 0.0060 secs
75% in 0.0066 secs
90% in 0.0068 secs
after
25% in 0.0044 secs
50% in 0.0046 secs
75% in 0.0048 secs
90% in 0.0059 secs
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.