Skip to content

[rllib] Fix multiagent example crash due to undefined abstract method#7329

Merged
ericl merged 2 commits intoray-project:masterfrom
ericl:fix-ma-example
Feb 27, 2020
Merged

[rllib] Fix multiagent example crash due to undefined abstract method#7329
ericl merged 2 commits intoray-project:masterfrom
ericl:fix-ma-example

Conversation

@ericl
Copy link
Copy Markdown
Contributor

@ericl ericl commented Feb 26, 2020

Why are these changes needed?

We shouldn't require the log likelihood method to be defined. This fixes the example and adds a test.

@ericl ericl requested a review from sven1977 February 26, 2020 01:52
@AmplabJenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22419/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22449/
Test FAILed.

@ericl ericl merged commit 58073f7 into ray-project:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants