Move plasma retry logic into plasma store provider#7328
Move plasma retry logic into plasma store provider#7328edoakes merged 6 commits intoray-project:masterfrom
Conversation
|
Can one of the admins verify this patch? |
|
Wasn't sure how to add a test for this, but verified locally that it works for both |
|
Test FAILed. |
| } else if (plasma::IsPlasmaObjectExists(plasma_status)) { | ||
| RAY_LOG(WARNING) << "Trying to put an object that already existed in plasma: " | ||
| << object_id << "."; | ||
| status = Status::OK(); |
There was a problem hiding this comment.
I think this probably isn't needed.
There was a problem hiding this comment.
Agreed but don't want to change it in this PR
There was a problem hiding this comment.
Oh I just meant the status = ... line, but yeah I guess the whole block could be removed.
stephanie-wang
left a comment
There was a problem hiding this comment.
A couple small comments, but looks good!
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test FAILed. |
Why are these changes needed?
Standardizes the behavior in all of the places in the code that we create objects in plasma. Will also be necessary to trigger global GC (see #7327).
Checks
scripts/format.shto lint the changes in this PR.