Skip to content

Move travis build script to after the deploy stage#6518

Merged
simon-mo merged 2 commits intoray-project:masterfrom
simon-mo:push-wheel-first
Dec 17, 2019
Merged

Move travis build script to after the deploy stage#6518
simon-mo merged 2 commits intoray-project:masterfrom
simon-mo:push-wheel-first

Conversation

@simon-mo
Copy link
Copy Markdown
Contributor

So we don't need to wait for the docker to build to test the wheels.

@simon-mo simon-mo requested a review from edoakes December 17, 2019 05:23
@AmplabJenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@simon-mo simon-mo merged commit 840d9c1 into ray-project:master Dec 17, 2019
@simon-mo
Copy link
Copy Markdown
Contributor Author

@edoakes feel free to cherry pick this to release branch

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19719/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/19718/
Test FAILed.

@robertnishihara
Copy link
Copy Markdown
Collaborator

One problem with this change is that now it is not tested in the CI, so if we break it in a PR we won't know. See #9720

@simon-mo @edoakes

@simon-mo
Copy link
Copy Markdown
Contributor Author

Agreed. @ijrsvt should we consider try to build the docker images (but not pushing them) in PR?

@ijrsvt
Copy link
Copy Markdown
Contributor

ijrsvt commented Jul 27, 2020

I think that building in PR is a waste of resources? It already seems like overkill to build the images in every commit. The images really don't change much because they are just dependencies and not the actual dev version of ray. That being said, I think we should start bundling ray in the image, but that may require us to use a different build infra.

@robertnishihara
Copy link
Copy Markdown
Collaborator

@ijrsvt how much resources are we talking about?

The issue is that if we only do it in the master, then if it breaks we won't know. Ideally the PR builds should catch all of the bugs.

We also build the wheels in the CI even though they are never used.

@ijrsvt
Copy link
Copy Markdown
Contributor

ijrsvt commented Jul 28, 2020

@robertnishihara It is mostly just downloading repos and running scripts. I totally forgot about our wheel building for PRs. I think in that light, it probably isn't much harm in adding it. Is it something that we should run on all PR builds or only those affecting docker files.

@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jul 28, 2020

@ijrsvt can we set up a separate travis job that only rebuilds the containers when the docker files are affected and always runs on master? I think that would be a good compromise.

@ijrsvt
Copy link
Copy Markdown
Contributor

ijrsvt commented Jul 28, 2020

That seems like a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants