[Data] Fix planner tests to handle tuple return from planner.plan()#62053
Merged
bveeramani merged 1 commit intomasterfrom Mar 25, 2026
Merged
[Data] Fix planner tests to handle tuple return from planner.plan()#62053bveeramani merged 1 commit intomasterfrom
bveeramani merged 1 commit intomasterfrom
Conversation
planner.plan() now returns a tuple (physical_plan, callbacks). Update tests to unpack the tuple instead of indexing into the result. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
iamjustinhsu
approved these changes
Mar 25, 2026
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
planner.plan()now returns a tuple(physical_plan, callbacks)after #61405. In this PR, I've updates the planner unit tests to unpack the tuple instead of indexing into the result.I'm doing this to make the return type a bit more explicit and readable.
Related issues
Related to #61405