Deflake test_xgboost_trainer tests#61655
Merged
justinvyu merged 1 commit intoray-project:masterfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the CPU allocation for three tests to resolve flakiness. The changes are straightforward. My feedback focuses on improving maintainability by adding comments that explain why these tests require more resources. This context is valuable for future developers working on this test suite.
justinvyu
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension of #61640. This PR resolves
test_fit_with_advanced_scaling_config,test_resume_from_checkpoint, andtest_checkpoint_freqintest_xgboost_trainertests from failing in CI by increasing their CPU resource allocations.