Merged
Conversation
fix serve minbuild ci base image Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the dependency installation scripts by updating curl commands. The flags are changed to -sSfL, which is a best practice for shell scripts. This ensures that curl will fail with a non-zero exit code on server errors (like 404), and thanks to set -e and pipefail, the script will correctly stop execution, preventing silent failures. The changes are correct and improve the reliability of the CI process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix serve minbuild ci base image