Skip to content

[DOC-127] Cherry-pick (#54254): MVP for OSS Ray labels#57547

Merged
aslonnie merged 2 commits intoray-project:releases/2.50.0from
MengjinYan:cherry-pick-2.50-54254
Oct 9, 2025
Merged

[DOC-127] Cherry-pick (#54254): MVP for OSS Ray labels#57547
aslonnie merged 2 commits intoray-project:releases/2.50.0from
MengjinYan:cherry-pick-2.50-54254

Conversation

@MengjinYan
Copy link
Copy Markdown
Contributor

(cherry picked from commit 44a9732)

Why are these changes needed?

This is to cherry-pick the label based scheduling OSS doc to the 2.50 release branch.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run pre-commit jobs to lint the changes in this PR. (pre-commit setup)
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MengjinYan MengjinYan added the go add ONLY when ready to merge, run all tests label Oct 8, 2025
@MengjinYan MengjinYan marked this pull request as ready for review October 8, 2025 17:23
@MengjinYan MengjinYan requested review from a team as code owners October 8, 2025 17:23
Copy link
Copy Markdown
Contributor

@dstrodtman dstrodtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

# Bundles require different labels:
ray.util.placement_group(
bundles=[{"CPU": 1}] + [{"GPU": 1} * 2],
bundle_label_selector=[{"ray.io/market-type": "spot"}] + [{"ray.io/accelerator-type": "H100"} * 2]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Invalid Dictionary Multiplication in Code Examples

The bundle_label_selector examples contain invalid Python syntax. Multiplying a dictionary by an integer, as seen in {"key": "value"} * 2, is not a valid operation and will result in a TypeError. This makes the provided code examples unusable.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure doc cherry-pick. @aslonnie for merge.

@ray-gardener ray-gardener bot added docs An issue or change related to documentation core Issues that should be addressed in Ray Core labels Oct 8, 2025
@aslonnie aslonnie merged commit fc4510f into ray-project:releases/2.50.0 Oct 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants