[rllib] Validate that entropy coeff is not an integer#5687
Merged
ericl merged 2 commits intoray-project:masterfrom Sep 11, 2019
Merged
[rllib] Validate that entropy coeff is not an integer#5687ericl merged 2 commits intoray-project:masterfrom
ericl merged 2 commits intoray-project:masterfrom
Conversation
Passing an integer value for entropy coeff such as 0 raises an error somewhere inside the TF policy graph, so this checks to make sure the entropy coeff is a float.
Contributor
|
Can't we cast to float32 somewhere instead? |
Also move this check after the negative value check
Contributor
Author
|
Makes sense, updated PR description as well |
ericl
approved these changes
Sep 11, 2019
|
Test PASSed. |
|
Test FAILed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Passing an integer value for entropy coeff such as 0 raises an error somewhere inside the TF policy graph.
This casts int values of entropy coeff to floats.
Related issue number
Closes #5686
Checks
scripts/format.shto lint the changes in this PR.