[rllib] Eager execution for centralized critic example, fix simple optimizer for multiagent#5683
Merged
ericl merged 6 commits intoray-project:masterfrom Sep 11, 2019
Merged
[rllib] Eager execution for centralized critic example, fix simple optimizer for multiagent#5683ericl merged 6 commits intoray-project:masterfrom
ericl merged 6 commits intoray-project:masterfrom
Conversation
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
richardliaw
reviewed
Sep 11, 2019
| sample_batch, | ||
| other_agent_batches=None, | ||
| episode=None): | ||
| sample_batch["advantages"] = discount(sample_batch["rewards"], 0.99) |
Contributor
There was a problem hiding this comment.
this should try to fetch gamma from policy config instead right
richardliaw
reviewed
Sep 11, 2019
| train_batch_size=1, | ||
| sgd_minibatch_size=0): | ||
| sgd_minibatch_size=0, | ||
| standardize_fields=[]): |
richardliaw
reviewed
Sep 11, 2019
| PolicyOptimizer.__init__(self, workers) | ||
|
|
||
| self.update_weights_timer = TimerStat() | ||
| self.standardize_fields = standardize_fields |
Contributor
Author
There was a problem hiding this comment.
Changed to froenzeset
richardliaw
approved these changes
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @eugenevinitsky