Raise error if space in redis password#5673
Merged
pcmoritz merged 3 commits intoray-project:masterfrom Sep 12, 2019
Merged
Conversation
Collaborator
Author
|
Tested locally for both |
|
Test PASSed. |
Member
|
@edoakes Thanks for this! Could you also mention it in the doc? (doc/source/configure.rst, Redis Port Authentication) |
pcmoritz
approved these changes
Sep 12, 2019
|
Test FAILed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently Ray will hang if you have a space in the redis password. We could support this but it will take somewhat more work, so we should at least throw an error.
Related issue number
Closes #5513
Checks
scripts/format.shto lint the changes in this PR.