Skip to content

[rllib] Improve accessing model state docs#5656

Merged
ericl merged 3 commits intoray-project:masterfrom
ericl:better-model-doc
Sep 9, 2019
Merged

[rllib] Improve accessing model state docs#5656
ericl merged 3 commits intoray-project:masterfrom
ericl:better-model-doc

Conversation

@ericl
Copy link
Copy Markdown
Contributor

@ericl ericl commented Sep 7, 2019

No description provided.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16878/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16880/
Test PASSed.

@ericl ericl added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 8, 2019
self.shape = self._init_shape(obs_space, options)
if not options:
from ray.rllib.models.catalog import MODEL_DEFAULTS
self._options = MODEL_DEFAULTS.copy()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be updated by options so that you provide defaults?

>>> policy.model.base_model.summary()
Model: "model"
_____________________________________________________________________
Layer (type) Output Shape Param # Connected to
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows up weird

@ericl ericl merged commit 74abeab into ray-project:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants