[projects] Wrap ProjectDefinition in a class#5654
[projects] Wrap ProjectDefinition in a class#5654pcmoritz merged 11 commits intoray-project:masterfrom
Conversation
|
Test PASSed. |
python/ray/projects/projects.py
Outdated
|
|
||
| def cluster_yaml(self): | ||
| """Return the project's cluster configuration filename. | ||
| """ |
There was a problem hiding this comment.
this should be same line as above
"""Return the project's cluster configuration filename."""
python/ray/projects/projects.py
Outdated
| """Return the project's working directory on a cluster session. | ||
| """ | ||
| directory = os.path.join("~", self.config["name"]) | ||
| if not directory.endswith("/"): |
There was a problem hiding this comment.
nit, you can do os.path.join("~", self.config["name"], ""), or generally os.path.join(path, "") for forcing path to be a directory
|
Looks great, there is a few test failures from the refactor :) |
|
Test PASSed. |
|
Test FAILed. |
pcmoritz
left a comment
There was a problem hiding this comment.
Great change, thanks :)
|
Test FAILed. |
Why are these changes needed?
Wraps some commonly needed project config values in one class. Also consolidates some helper functions.
Checks
scripts/format.shto lint the changes in this PR.