Skip to content

Consolidate and clean up documentation#5645

Merged
ericl merged 17 commits intoray-project:masterfrom
ericl:revise-internal-doc
Sep 7, 2019
Merged

Consolidate and clean up documentation#5645
ericl merged 17 commits intoray-project:masterfrom
ericl:revise-internal-doc

Conversation

@ericl
Copy link
Copy Markdown
Contributor

@ericl ericl commented Sep 5, 2019

This mostly touches the first section of the docs. I also added some stuff to the RLlib training docs to extend the table of contents.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Sep 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16817/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Sep 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16835/
Test FAILed.

richardliaw
richardliaw reviewed Sep 6, 2019
View reviewed changes
doc/source/object-store.rst
@@ -1,82 +1,79 @@
Object Store and Serialization
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename file to serialization.rst and update index.rst?

richardliaw
richardliaw reviewed Sep 6, 2019
View reviewed changes
rllib/models/tf/tf_modelv2.py
else:
self.graph = tf.get_default_graph()

def context(self):
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graph context?

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Sep 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16837/
Test FAILed.

richardliaw
richardliaw reviewed Sep 7, 2019
View reviewed changes
doc/source/walkthrough.rst Outdated
This happens in approximate LRU (least recently used) order. To avoid objects from
being evicted, you can call ``ray.get`` and store their values instead. Numpy array
objects cannot be evicted while they are mapped in any Python process. You can also
configure `memory limits <memory-management>`__ to control object store usage by
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw Sep 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
configure `memory limits <memory-management>`__ to control object store usage by
configure `memory limits <memory-management.html>`__ to control object store usage by

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Sep 7, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16848/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Sep 7, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16849/
Test FAILed.

@ericl ericl merged commit 1455a19 into ray-project:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericl @AmplabJenkins @richardliaw