Skip to content

[Docs] Adds third notebook to time-series tutorial#53567

Closed
crypdick wants to merge 0 commit intomasterfrom
docs/e2e-ts-notebook-3
Closed

[Docs] Adds third notebook to time-series tutorial#53567
crypdick wants to merge 0 commit intomasterfrom
docs/e2e-ts-notebook-3

Conversation

@crypdick
Copy link
Copy Markdown
Contributor

@crypdick crypdick commented Jun 4, 2025

Why are these changes needed?

Adds third and final tutorial to time-series example. Do not merge until #53561 is merged.

Related issue number

NA

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@crypdick crypdick requested a review from a team as a code owner June 4, 2025 22:32
@crypdick crypdick added the docs An issue or change related to documentation label Jun 4, 2025
@crypdick crypdick requested a review from GokuMohandas June 4, 2025 22:39
@crypdick crypdick added the go add ONLY when ready to merge, run all tests label Jun 4, 2025
"- autoscales based on real-time incoming traffic\n",
"- covers observability and debugging around the service\n",
"\n",
"Note that this notebook requires that you run the [Distributed training of a DLinear model](./01-Distributed-Training.ipynb) tutorial to generate the pre-trained model artifacts that this tutorial fetches.\n",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This internal link is nice. I noticed that you didn't do it in the second notebook and assumed it was because it wouldn't work in the Anyscale template. I suggest treating the reference consistently in this and the second notebooks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not actually sure that this will work as expected in Workspaces, this is a little experiment I'm running

@crypdick crypdick requested a review from a team June 5, 2025 22:17
@aslonnie aslonnie removed the request for review from a team June 6, 2025 00:43
Copy link
Copy Markdown
Contributor

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave it for @aslonnie to review

Copy link
Copy Markdown
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase/merge the PR properly. it is incorrectly including changes that are already merged in master.

Base automatically changed from docs/e2e-ts-notebook-2 to master June 10, 2025 00:06
@angelinalg angelinalg enabled auto-merge (squash) June 10, 2025 00:07
@github-actions github-actions bot disabled auto-merge June 10, 2025 00:07
@crypdick crypdick closed this Jun 10, 2025
@crypdick crypdick force-pushed the docs/e2e-ts-notebook-3 branch from 37e5f78 to 6c9633c Compare June 10, 2025 00:17
@crypdick crypdick deleted the docs/e2e-ts-notebook-3 branch June 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants