Skip to content

add vale to pre-commit#53564

Merged
angelinalg merged 2 commits intoray-project:masterfrom
vigneshka:vigneshka/add-vale-to-pre-commit
Jun 9, 2025
Merged

add vale to pre-commit#53564
angelinalg merged 2 commits intoray-project:masterfrom
vigneshka:vigneshka/add-vale-to-pre-commit

Conversation

@vigneshka
Copy link
Copy Markdown
Contributor

@vigneshka vigneshka commented Jun 4, 2025

Vale linting fails CI, so should be added to pre commit

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Vignesh Hirudayakanth <vigneshkanth@gmail.com>
@vigneshka vigneshka force-pushed the vigneshka/add-vale-to-pre-commit branch from 2784c65 to 75e7375 Compare June 4, 2025 21:27
Signed-off-by: Vignesh Hirudayakanth <vigneshkanth@gmail.com>
@angelinalg angelinalg added the go add ONLY when ready to merge, run all tests label Jun 9, 2025
@angelinalg angelinalg enabled auto-merge (squash) June 9, 2025 18:11
@angelinalg angelinalg merged commit 6077a93 into ray-project:master Jun 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants