[Core] Use a FIPS BoringSSL build#53173
Closed
JoshKarpel wants to merge 7 commits intoray-project:masterfrom
Closed
[Core] Use a FIPS BoringSSL build#53173JoshKarpel wants to merge 7 commits intoray-project:masterfrom
JoshKarpel wants to merge 7 commits intoray-project:masterfrom
Conversation
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We would like to run Ray with Ray's built-in TLS support for its gRPC channels https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/tls.html with FIPS 140-3 support. It looks like the critical component here is BoringSSL, which is Google's fork of OpenSSL that is used for TLS in gRPC.
Since Ray statically links BoringSSL into the build, we need to change what version of BoringSSL is linked into Ray at build time to achieve this. It looks like the way to do this is to select a FIPS-compliant release of BoringSSL to pull into the Bazel build. I've left comments in the config about which build I chose and why.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.