Ray Train Test: Add locality_with_output, actor_locality_enabled option#52000
Merged
srinathk10 merged 4 commits intosrinathk10-train_cleanup_locality_hintsfrom Apr 7, 2025
Conversation
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
release/train_tests/benchmark/config.py:42
- [nitpick] Consider adding unit or integration tests to verify the behavior of the new locality_with_output option.
locality_with_output: bool = False
raulchen
approved these changes
Apr 4, 2025
Contributor
|
TIL, you can add Copilot to review your PR |
Signed-off-by: srinathk10 <68668616+srinathk10@users.noreply.github.com>
Contributor
Author
|
https://buildkite.com/ray-project/release/builds/38020 |
…0-train_benchmark_locality_hints
e70b663
into
srinathk10-train_cleanup_locality_hints
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray Train Release test: Add locality_with_output, actor_locality_enabled option
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.