Skip to content

Fix Java MultithreadingTest#5182

Merged
raulchen merged 1 commit intoray-project:masterfrom
antgroup:fix_multithreading_test
Jul 12, 2019
Merged

Fix Java MultithreadingTest#5182
raulchen merged 1 commit intoray-project:masterfrom
antgroup:fix_multithreading_test

Conversation

@raulchen
Copy link
Copy Markdown
Contributor

@raulchen raulchen commented Jul 12, 2019

What do these changes do?

I tried fixing this test at #5170 by increasing the timeout. But it still fails occasionally.
This PR fixes this again by warming up the worker pool. Should make this test much less sensitive to time.

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@raulchen raulchen requested a review from jovany-wang July 12, 2019 07:30
Copy link
Copy Markdown
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1643/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15335/
Test PASSed.

@raulchen raulchen merged commit 0ec3a16 into ray-project:master Jul 12, 2019
@raulchen raulchen deleted the fix_multithreading_test branch July 12, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants