Skip to content

[sgd] Deprecate old distributed SGD implementation#5160

Merged
richardliaw merged 2 commits intoray-project:masterfrom
pschafhalter:sgd-deprecate-old
Jul 22, 2019
Merged

[sgd] Deprecate old distributed SGD implementation#5160
richardliaw merged 2 commits intoray-project:masterfrom
pschafhalter:sgd-deprecate-old

Conversation

@pschafhalter
Copy link
Copy Markdown
Contributor

@pschafhalter pschafhalter commented Jul 10, 2019

What do these changes do?

  • Removes old experimental SGD implementation

Related issue number

Closes #5093

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 10, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15273/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 10, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1583/
Test FAILed.

@richardliaw
Copy link
Copy Markdown
Contributor

richardliaw commented Jul 10, 2019

does README of the repo need to change?

@richardliaw richardliaw self-assigned this Jul 10, 2019
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 10, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1594/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jul 10, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15284/
Test PASSed.

@ericl
Copy link
Copy Markdown
Contributor

ericl commented Jul 10, 2019

You also want to remove the jenkins tests from run_multi_node_tests.sh

@pschafhalter
Copy link
Copy Markdown
Contributor Author

pschafhalter commented Jul 11, 2019

You also want to remove the jenkins tests from run_multi_node_tests.sh

I think I removed those already in a previous PR since they were failing.

@richardliaw richardliaw merged commit fc58905 into ray-project:master Jul 22, 2019
@jichan3751 jichan3751 mentioned this pull request Jul 23, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SGD] Deprecate old TF SGD code

4 participants

@pschafhalter @AmplabJenkins @richardliaw @ericl