[ADAG] Refactor nccl to communicator channel.#48607
Closed
Bye-legumes wants to merge 13 commits intoray-project:masterfrom
Closed
[ADAG] Refactor nccl to communicator channel.#48607Bye-legumes wants to merge 13 commits intoray-project:masterfrom
Bye-legumes wants to merge 13 commits intoray-project:masterfrom
Conversation
Contributor
Author
|
see #47658 |
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previous #47845
This is try to enable the ADAG channel can use different hardware while the user API keeps the same.
For user side, they can use
transport='nccl'ortransport='hccl'for different hardware.While internally, ADAG will treat them the nodes that needs the communicator. So for the complied and channel level, it just rename the nccl to communicator.
In the bottom level, the
nccl_grouporhccl_groupwill be called to achieve the hardware level communicator.The API and logical above the
torch_tensor_communicator_channel.pypreviouslytorch_tensor_nccl_channel.pykeeps the same.So when new accelerator will be used, what they need is just implement xccl_group, with same API for all groups. Then we can use new hardware.
RFC doc https://docs.google.com/document/d/1zu9SllrEAjPHqs-eeITtrSSbv0rBxtkyCJeweZJl100/edit?usp=sharing
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.