Skip to content

[rllib] Fix error getting kl when simple_optimizer: True in multi-agent PPO#4849

Merged
ericl merged 1 commit intoray-project:masterfrom
ericl:fix-simple-opt-ma
May 28, 2019
Merged

[rllib] Fix error getting kl when simple_optimizer: True in multi-agent PPO#4849
ericl merged 1 commit intoray-project:masterfrom
ericl:fix-simple-opt-ma

Conversation

@ericl
Copy link
Copy Markdown
Contributor

@ericl ericl commented May 24, 2019

What do these changes do?

It seems like this has been broken for a while, but we didn't notice since simple_optimizer: False by default.

Related issue number

Closes #4839

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@ericl ericl mentioned this pull request May 24, 2019
Closed
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented May 24, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/917/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented May 24, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14384/
Test FAILed.

@ericl
Copy link
Copy Markdown
Contributor Author

ericl commented May 24, 2019

jenkins retest this please

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented May 24, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/923/
Test FAILed.

@ericl ericl mentioned this pull request May 24, 2019
Merged
1 task
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented May 24, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14389/
Test FAILed.

@ericl
Copy link
Copy Markdown
Contributor Author

ericl commented May 25, 2019

jenkins retest this please

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented May 26, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/14423/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented May 26, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/958/
Test PASSed.

@ericl ericl merged commit d7be5a5 into ray-project:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes

+1 more reviewer

@nathanlct nathanlct nathanlct approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@richardliaw richardliaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[rllib] pi.update_kl(fetches[pi_id]["kl"]) KeyError: 'kl'

4 participants

@ericl @AmplabJenkins @richardliaw @nathanlct