Skip to content

uint8_t* data ptr not used.#47565

Merged
edoakes merged 3 commits intoray-project:masterfrom
SeanQuant:master
Jun 9, 2025
Merged

uint8_t* data ptr not used.#47565
edoakes merged 3 commits intoray-project:masterfrom
SeanQuant:master

Conversation

@SeanQuant
Copy link
Copy Markdown
Contributor

@SeanQuant SeanQuant commented Sep 9, 2024 •
edited
Loading

uint8_t* data ptr not used, so I just delete it.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@SeanQuant
[Update serialization.pxi] uint8_t* data ptr not used, so delete.
5a31844 
uint8_t* data ptr not used.

Signed-off-by: Sean <117848263+SeanQuant@users.noreply.github.com>
@SeanQuant
Merge pull request #1 from SeanQuant/SeanQuant-patch-1
24bafdc 
[Update serialization.pxi] uint8_t* data ptr not used, so delete.
@anyscalesam anyscalesam added the go add ONLY when ready to merge, run all tests label Sep 16, 2024
@anyscalesam anyscalesam self-requested a review September 16, 2024 21:59
SeanQuant

This comment was marked as duplicate.

Sign in to view

@stale
Copy link
Copy Markdown

stale bot commented Feb 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 1, 2025
@cszhu cszhu added the core Issues that should be addressed in Ray Core label Apr 3, 2025
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 3, 2025
@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 4, 2025
@stale
Copy link
Copy Markdown

stale bot commented May 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 6, 2025
@codope codope self-assigned this May 27, 2025
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 27, 2025
codope
codope approved these changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanQuant Thanks for the contribution! Could you please rebase the PR?

@edoakes edoakes merged commit d96edaf into ray-project:master Jun 9, 2025
5 checks passed
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 9, 2025

Thanks @SeanQuant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codope codope codope approved these changes

@anyscalesam anyscalesam Awaiting requested review from anyscalesam

Assignees

@codope codope

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SeanQuant @edoakes @codope @cszhu @hainesmichaelc @anyscalesam