fixed typo in kuber yaml#4582
fixed typo in kuber yaml#4582robertnishihara merged 1 commit intoray-project:masterfrom DuaneNielsen:master
Conversation
|
Okies, here tis |
|
Can one of the admins verify this patch? |
|
@virtualluke Does this look right to you? |
|
Test FAILed. |
|
Lol, dunno how that change can cause a test to fail :) |
|
Thanks @DuaneNielsen! Some of our tests are flaky unfortunately. What command did you use to validate the config file? Maybe we should run that in our CI. |
|
Sorry for the typo, to put a test I guess we could add a minikube run with the files (adds a lot of complexity I guess with k8s versions/platform), guessing other people have done that for testing and if you think it worthwhile I can explore. Anyone else done this that is reading this? |
|
Well, I just ran I only got a warning though... so dunno if that would even cause a failed build. But a quick google reveals we are not the first to run into this challenge. So through the wonders of open source... |
|
I also ran the PR that introduced the typo in minikube before merging it and it still succeeded. |
What do these changes do?
Related issue number
Linter
scripts/format.shto lint the changes in this PR.