[serve] Avoid deleting dynamically-deployed apps when applying config via REST API#44476
Merged
edoakes merged 7 commits intoray-project:masterfrom Apr 4, 2024
Merged
[serve] Avoid deleting dynamically-deployed apps when applying config via REST API#44476edoakes merged 7 commits intoray-project:masterfrom
edoakes merged 7 commits intoray-project:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #44226 for more details, but TL;DR:
serve.runAPI. In this case, we should not delete the dynamically-created apps.APITypeand only deleting apps that were applied via the declarative API. There is no public API change. In the future we may want to consider exposing this metadata so external systems like Kuberay can treat the types of apps differently (e.g., for determining high-level status).Related issue number
Closes #44226
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.