-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Update cloudpickle to version 0.5.6 (a couple commits after actually). #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudpickle to version 0.5.6 (a couple commits after actually). #2928
Conversation
|
Test FAILed. |
|
Test FAILed. |
|
jenkins, retest this please |
|
Test FAILed. |
|
It's strange that |
|
jenkins, retest this please |
|
Test FAILed. |
|
jenkins, retest this please |
|
The error appears to be in |
|
Test FAILed. |
|
odd; I guess somehow this causes cloudpickle to not capture the scope completely correctly? |
|
BTW, I am guessing that eventually having also this fix in might saves us some trouble. We are slowly porting code to use typing and it seems with Python 3.6 there could be troubles. So, maybe Ray could update cloudpickle to version which is includes that PR. (But we have not yet had been blocked by this, but we encountered in the past and found some workarounds.) |
|
@suquark Could you check why tests here are failing? |
This brings in a number of recent cloudpickle fixes and may address #2685. This copies cloudpickle.py directly from cloudpipe/cloudpickle@06b18af.