[AIR] GNN example cleanup#24080
Merged
amogkam merged 4 commits intoray-project:masterfrom Apr 22, 2022
Merged
Conversation
6 tasks
gjoliver
approved these changes
Apr 21, 2022
Member
gjoliver
left a comment
There was a problem hiding this comment.
thanks for making the followup changes!
| return fake_dataset | ||
|
|
||
|
|
||
| def gen_reddit_dataset(): |
Member
There was a problem hiding this comment.
actually we can simplify this too right?
Contributor
Author
There was a problem hiding this comment.
actually- sorry I've confused myself. For the fake dataset, we had to do it the original way because we want the same dataset for all the workers (so we create the fake dataset on the driver, and have the same dataset returned on all the workers).
For reddit dataset, you're right we can simplify this.
Updated the PR!
|
|
||
| @torch.no_grad() | ||
| def inference(self, x_all, subgraph_loader): | ||
| def test(self, x_all, subgraph_loader): |
Member
There was a problem hiding this comment.
oh, dude, test() makes so much more sense!!
thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup for GNN example
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.