Skip to content

[Docs] Automatically render latest ray_lightning docs#23729

Merged
amogkam merged 9 commits intoray-project:masterfrom
amogkam:render-ray-lightning-docs
Apr 8, 2022
Merged

[Docs] Automatically render latest ray_lightning docs#23729
amogkam merged 9 commits intoray-project:masterfrom
amogkam:render-ray-lightning-docs

Conversation

@amogkam
Copy link
Copy Markdown
Contributor

@amogkam amogkam commented Apr 6, 2022

Automatically pull the latest ray_lightning README to render on Ray docs. (#23505)

Depends on ray-project/ray_lightning#135

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Copy Markdown
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the process! I would keep a dummy file for the Ray lighting docs page in, though. It allows to see where it would be placed in the docs structure at a glance, before building them.

@amogkam amogkam merged commit 5a41fb1 into ray-project:master Apr 8, 2022
@amogkam amogkam deleted the render-ray-lightning-docs branch April 8, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants