[Datasets] Tie _DesignatedBlockOwner lifetime to context creator#22007
Merged
ericl merged 1 commit intoray-project:masterfrom Feb 1, 2022
Merged
Conversation
…esignatedBlockOwner if dynamic block splitting is enabled.
ericl
approved these changes
Jan 31, 2022
Contributor
Author
|
Datasets tests pass, ready to merge. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a detached lifetime, tie the lifetime of
_DesignatedBlockOwnerto the lifetime of the context creator. Also, only create a_DesignatedBlockOwnerif dynamic block splitting is enabled.Related issue number
Closes #21999
Checks
scripts/format.shto lint the changes in this PR.