Skip to content

Avoid runtime env overhead when it's empty#21780

Closed
jjyao wants to merge 1 commit intoray-project:masterfrom
jjyao:jjyao/runtime
Closed

Avoid runtime env overhead when it's empty#21780
jjyao wants to merge 1 commit intoray-project:masterfrom
jjyao:jjyao/runtime

Conversation

@jjyao
Copy link
Copy Markdown
Contributor

@jjyao jjyao commented Jan 21, 2022

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao added the do-not-merge Do not merge this PR! label Jan 21, 2022
@jjyao
Copy link
Copy Markdown
Contributor Author

jjyao commented Jan 21, 2022

Seems, the line I commented out does have some performance impact. Now the time is stage_3_time = 2397.899885416031 based on https://buildkite.com/ray-project/periodic-ci/builds/2450#_.

@rkooo567
Copy link
Copy Markdown
Contributor

Close it as duplicate!

@rkooo567 rkooo567 closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants