[Core] Disable formatting in test_add_min_workers_nodes#21322
Merged
pcmoritz merged 2 commits intoray-project:masterfrom Jan 2, 2022
Merged
[Core] Disable formatting in test_add_min_workers_nodes#21322pcmoritz merged 2 commits intoray-project:masterfrom
test_add_min_workers_nodes#21322pcmoritz merged 2 commits intoray-project:masterfrom
Conversation
pcmoritz
approved these changes
Jan 2, 2022
Contributor
pcmoritz
left a comment
There was a problem hiding this comment.
Test failures are unrelated, merging this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Black errors while formatting
test_resource_demand_scheduler.py. The issue is caused by the assertions at the end oftest_add_min_workers_nodes.To prevent
format.shfrom erroring once we switch to Black, I've disabled formatting around the assertions.Related issue number
Closes #21313. See also #21311.
Checks
scripts/format.shto lint the changes in this PR.